HACKING 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404
  1. ============================================================================
  2. = This file
  3. * This file attempts to describe the rules to use when hacking
  4. automake.
  5. ============================================================================
  6. = Administrivia
  7. * The correct response to most actual bugs is to write a new test case
  8. which demonstrates the bug. Then fix the bug, re-run the test suite,
  9. and check everything in.
  10. * If you incorporate a change from somebody on the net:
  11. - First, if it is a large change, you must make sure they have
  12. signed the appropriate paperwork.
  13. - Second, be sure to add their name and email address to THANKS.
  14. * If a change fixes a test, mention the test in the commit message.
  15. If a change fixes a bug registered in the Automake debbugs tracker,
  16. mention the bug number in the commit message.
  17. * If somebody reports a new bug, mention his name in the commit message
  18. that fixes or exposes the bug, and put him into THANKS.
  19. * When documenting a non-trivial idiom or example in the manual, be
  20. sure to add a test case for it, and to reference such test case from
  21. a proper Texinfo comment.
  22. * Some files in the automake package are not owned by automake; these
  23. files are listed in the $(FETCHFILES) variable in Makefile.am. They
  24. should never be edited here. Almost all of them can be updated from
  25. respective upstreams with "make fetch" (this should be done especially
  26. before releases). The only exception is the 'lib/COPYING' (from FSF),
  27. which should be updated by hand whenever the GPL gets updated (which
  28. shouldn't happen that often anyway :-)
  29. * Changes other than *trivial* bug fixes must be mentioned in NEWS.
  30. * Changes which are potentially controversial, require a non-trivial
  31. plan, or must be implemented gradually with a roadmap spanning several
  32. releases (either minor or major) should be discussed on the list,
  33. and have a proper entry in the PLANS directory. This entry should be
  34. always committed in the "maint" branch, even if the change it deals
  35. with is only for the master branch, or a topic branch. Usually, in
  36. addition to this, it is useful to open a "wishlist" report on the
  37. Automake debbugs tracker, to keep the idea more visible, and have the
  38. discussions surrounding it easily archived in a central place.
  39. ============================================================================
  40. = Naming
  41. * We've adopted the convention that internal AC_SUBSTs and make variables
  42. should be named with a leading 'am__', and internally generated targets
  43. should be named with a leading 'am--'. This convention, although in
  44. place from at least February 2001, isn't yet universally used.
  45. But all new code should use it.
  46. We used to use '_am_' as the prefix for an internal AC_SUBSTs.
  47. However, it turns out that NEWS-OS 4.2R complains if a Makefile
  48. variable begins with the underscore character. Yay for them.
  49. I changed the target naming convention just to be safe.
  50. ============================================================================
  51. = Editing '.am' files
  52. * Always use $(...) and not ${...}
  53. * Prefer ':' over 'true', mostly for consistency with existing code.
  54. * Use '##' comments liberally. Comment anything even remotely unusual.
  55. * Never use basename or dirname. Instead, use sed.
  56. * Do not use 'cd' within back-quotes, use '$(am__cd)' instead.
  57. Otherwise the directory name may be printed, depending on CDPATH.
  58. More generally, do not ever use plain 'cd' together with a relative
  59. directory that does not start with a dot, or you might end up in one
  60. computed with CDPATH.
  61. * For install and uninstall rules, if a loop is required, it should be
  62. silent. Then the body of the loop itself should print each "important"
  63. command it runs. The printed commands should be preceded by a single
  64. space.
  65. * Ensure install rules do not create any installation directory where
  66. nothing is to be actually installed. See automake bug#11030.
  67. ============================================================================
  68. = Editing automake.in and aclocal.in
  69. * Indent using GNU style. For historical reasons, the perl code
  70. contains portions indented using Larry Wall's style (perl-mode's
  71. default), and other portions using the GNU style (cperl-mode's
  72. default). Write new code using GNU style.
  73. * Don't use & for function calls, unless really required.
  74. The use of & prevents prototypes from being checked.
  75. ============================================================================
  76. = Automake versioning and compatibility scheme
  77. * There are three kinds of automake releases:
  78. - new major releases (e.g., 2.0, 5.0)
  79. - new minor releases (e.g., 1.14, 2.1)
  80. - micro a.k.a. "bug-fixing" releases (e.g., 1.13.2, 2.0.1, 3.5.17).
  81. A new major release should have the major version number bumped, and
  82. the minor and micro version numbers reset to zero. A new minor release
  83. should have the major version number unchanged, the minor version number
  84. bumped, and the micro version number reset to zero. Finally, a new
  85. micro version should have the major and minor version numbers unchanged,
  86. and the micro version number bumped by one.
  87. For example, the first minor version after 1.13.2 will be 1.14; the
  88. first bug-fixing version after 1.14 that will be 1.14.1; the first
  89. new major version after all such releases will be 2.0; the first
  90. bug-fixing version after 2.0 will be 2.0.1; and a further bug-fixing
  91. version after 2.0.1 will be 2.0.2.
  92. * Micro releases should be just bug-fixing releases; no new features
  93. should be added, and ideally, only trivial bugs, recent regressions,
  94. or documentation issues should be addressed by them. On the other
  95. hand, it's OK to include testsuite work and even testsuite refactoring
  96. in a micro version, since a regression there is not going to annoy or
  97. inconvenience Automake users, but only the Automake developers.
  98. * Minor releases can introduce new "safe" features, do non-trivial but
  99. mostly safe code clean-ups, and even add new runtime warnings (rigorously
  100. non-fatal). But they shouldn't include any backward incompatible change,
  101. nor contain any potentially destabilizing refactoring or sweeping change,
  102. nor introduce new features whose implementation might be liable to cause
  103. bugs or regressions in existing code. However, it might be acceptable to
  104. introduce very limited and localized backward-incompatibilities, *only*
  105. if that is necessary to fix non-trivial bugs, address serious performance
  106. issues, or greatly enhance usability. But please, do this sparsely and
  107. rarely!
  108. * Major releases can introduce backward-incompatibilities (albeit such
  109. incompatibilities should be announced well in advance, and a smooth
  110. transition plan prepared for them), and try more risking and daring
  111. refactorings and code cleanups.
  112. * For more information, refer to the extensive discussion associated
  113. with automake bug#13578.
  114. ============================================================================
  115. = Working with git
  116. * To regenerate dependent files created by aclocal and automake,
  117. use the 'bootstrap' script. It uses the code from the source
  118. tree, so the resulting files (aclocal.m4 and Makefile.in) should
  119. be the same as you would get if you install this version of
  120. automake and use it to generate those files. Be sure to have the
  121. latest stable version of Autoconf installed and available early
  122. in your PATH.
  123. * The Automake git tree currently carries three basic branches: 'micro',
  124. 'maint' and 'master'.
  125. * The 'micro' branch, reserved to changes that should go into the next
  126. micro release; so it will just see fixes for regressions, trivial
  127. bugs, or documentation issues, and no "active" development whatsoever.
  128. Since emergency regression-fixing or security releases could be cut
  129. from this branch at any time, it should always be kept in a releasable
  130. state.
  131. * The 'maint' branch is where the development of the next minor release
  132. takes place. It should be kept in a stable, almost-releasable state,
  133. to simplify testing and deploying of new minor version. Note that
  134. this is not a hard rule, and such "stability" is not expected to be
  135. absolute (emergency releases are cut from the 'micro' branch anyway).
  136. * The 'master' branch is reserved for the development of the next major
  137. release. Experimenting a little is OK here, but don't let the branch
  138. grow too unstable; if you need to do exploratory programming or
  139. over-arching change, you should use a dedicated topic branch, and
  140. only merge that back once it is reasonably stable.
  141. * The 'micro' branch should be kept regularly merged into the 'maint'
  142. branch, and the 'maint' branch into the 'master' branch. It is advisable
  143. to merge only after a set of related commits have been applied, to avoid
  144. introducing too much noise in the history.
  145. * There may be a number of longer-lived feature branches for new
  146. developments. They should be based off of a common ancestor of all
  147. active branches to which the feature should or might be merged later.
  148. * After a new minor release is done, the 'maint' branch is to be merged
  149. into the 'micro' branch, and then a "new" 'maint' branch created
  150. stemming from the resulting commit.
  151. Similarly, after a new major release is done, the 'master' branch is to
  152. be merged into both the 'micro' and 'maint' branches, and then "new"
  153. 'master' branch created stemming from the resulting commit.
  154. * When fixing a bug (especially a long-standing one), it may be useful
  155. to commit the fix to a new temporary branch based off the commit that
  156. introduced the bug. Then this "bugfix branch" can be merged into all
  157. the active branches descending from the buggy commit. This offers a
  158. simple way to fix the bug consistently and effectively.
  159. * When merging, prefer 'git merge --log' over plain 'git merge', so that
  160. a later 'git log' gives an indication of which actual patches were
  161. merged even when they don't appear early in the list.
  162. * The 'master', 'maint' and 'micro' branches should not be rewound, i.e.,
  163. should always fast-forward, except maybe for privacy issues. For
  164. feature branches, the announcement for the branch should document
  165. the rewinding policy.
  166. If a topic branch is expected to be rewound, it is good practice to put
  167. it in the 'experimental/*' namespace; for example, a rewindable branch
  168. dealing with Vala support could be named like "experimental/vala-work".
  169. ============================================================================
  170. = Writing a good commit message
  171. * Here is the general format that Automake's commit messages are expected
  172. to follow. See the further points below for clarifications and minor
  173. corrections.
  174. topic: brief description (this is the "summary line")
  175. <reference to relevant bugs, if any>
  176. Here goes a more detailed explanation of why the commit is needed,
  177. and a general overview of what it does, and how. This section
  178. should almost always be provided, possibly only with the expection
  179. of obvious fixes or very trivial changes.
  180. And if the detailed explanation is quite long or detailed, you can
  181. want to break it in more paragraphs.
  182. Then you can add references to relevant mailing list discussions
  183. (if any), with proper links. But don't take this as an excuse for
  184. writing incomplete commit messages! The "distilled" conclusions
  185. reached in such discussions should have been placed in the
  186. paragraphs above.
  187. Finally, here you can thank people that motivated or helped the
  188. change. So, thanks to John Doe for bringing up the issue, and to
  189. J. Random Hacker for providing suggestions and testing the patch.
  190. <detailed list of touched files>
  191. * The <detailed list of touched files> should usually be provided (but
  192. for short or trivial changes), and should follow the GNU guidelines
  193. for ChangeLog entries (described explicitly in the GNU Coding
  194. Standards); it might be something of this sort:
  195. * some/file (func1): Improved frobnication.
  196. (func2): Adjusted accordingly.
  197. * another/file (foo, bar): Likewise.
  198. * tests/foo.tap: New test.
  199. * tests/Makefile.am (TESTS): Add it.
  200. * If your commit fixes an automake bug registered in the tracker (say
  201. numbered 1234), you should put the following line after the summary
  202. line:
  203. This change fixes automake bug#1234.
  204. * If your commit is just related to the given bug report, but does not
  205. fix it, you might want to add a line like this instead:
  206. This change is related to automake bug#1234.
  207. * When referring to older commits, use 'git describe' output as pointer.
  208. But also try to identify the given commit by date and/or summary line
  209. if possible. Examples:
  210. Since yesterday's commit, v1.11-2019-g4d2bf42, ...
  211. ... removed in commit 'v1.11-1674-g02e9072' of 01-01-2012,
  212. "dist: ditch support for lzma"...
  213. ============================================================================
  214. = Test suite
  215. * Use "make check" and "make maintainer-check" liberally.
  216. * Export the 'keep_testdirs' environment variable to "yes" to keep
  217. test directories for successful tests also.
  218. * Use perl coverage information to ensure your new code is thoroughly
  219. tested by your new tests.
  220. * See file 't/README' for more information.
  221. ============================================================================
  222. = Release procedure
  223. * The steps outlined here are meant to be followed for alpha and stable
  224. releases as well. Where differences are expected, they will be
  225. explicitly described.
  226. * Fetch new versions of the files that are maintained by the FSF by
  227. running "make fetch". In case any file in the automake repository
  228. has been updated, commit and re-run the testsuite.
  229. * Ensure that the copyright notices of the distributed files is up to
  230. date. The maintainer-only target "update-copyright" can help with
  231. this.
  232. * Check NEWS; in particular, ensure that all the relevant differences
  233. with the last release are actually reported.
  234. * Update the version number in configure.ac.
  235. (The idea is that every other alpha number will be a net release.
  236. The repository will always have its own "odd" number so we can easily
  237. distinguish net and repo versions.)
  238. * Run these commands, in this order:
  239. make bootstrap
  240. make check keep_testdirs=yes
  241. make maintainer-check
  242. make distcheck
  243. make check-no-trailing-backslash-in-recipes
  244. make check-cc-no-c-o
  245. It is also advised to run "git clean -fdx" before invoking the
  246. bootstrap, to ensure a really clean rebuild. However, it must
  247. be done carefully, because that command will remove *all* the
  248. files that are not tracked by git!
  249. * Run "make git-tag-release".
  250. This will run the maintainer checks, verify that the local git
  251. repository and working tree are clean and up-to-date, and create
  252. a proper signed git tag for the release (based on the contents
  253. of $(VERSION)).
  254. * Run "make git-upload-release".
  255. This will first verify that you are releasing from a tagged version
  256. and that the local git repository and working tree are clean and
  257. up-to-date, and will then run "make dist" to create the tarballs,
  258. and invoke the 'gnupload' script sign and upload them to the correct
  259. locations. In case you need to sign with a non-default key, you can
  260. use "make GNUPLOADFLAGS='--user KEY' git-upload-release".
  261. * For stable releases you'll have to update the manuals at www.gnu.org.
  262. - Generate manuals (with the help of the standard gendocs.sh script):
  263. make web-manual
  264. The ready-to-be-uploaded manuals (in several formats) will be left
  265. in the 'doc/web-manuals' directory.
  266. - Commit the updated manuals to web CVS:
  267. make web-manual-update
  268. If your local username is different from your username at Savannah,
  269. you'll have to override the 'CVS_USER' make variable accordingly;
  270. for example:
  271. make web-manual-update CVS_USER=slattarini
  272. - Check for link errors, fix them, recheck until convergence:
  273. <http://validator.w3.org/checklink>
  274. * Create an announcement message with "make announcement". Edit the
  275. generated 'announcement' file appropriately, in particularly filling
  276. in by hand any "TODO" left in there.
  277. * Update version number in configure.ac to next alpha number.
  278. Re-run ./bootstrap and commit.
  279. * Don't forget to "git push" your changes so they appear in the public
  280. git tree.
  281. * Send the announcement generated in the earlier steps at least to
  282. <autotools-announce@gnu.org> and <automake@gnu.org>. If the release
  283. is a stable one, the announcement must also go to <info-gnu@gnu.org>;
  284. if it is an alpha or beta release, announcement should be sent also
  285. to <platform-testers@gnu.org>, to maximize the possibility of early
  286. testing on exotic or proprietary systems. Finally, copy an abridged
  287. version of the announcement into the NEWS feed at:
  288. <https://savannah.gnu.org/projects/automake>.
  289. Be sure to link a version to the complete announcement (from
  290. the version you sent to the automake list, as get archived on
  291. <http://lists.gnu.org/archive/html/automake/>).
  292. -----
  293. Copyright (C) 2003-2017 Free Software Foundation, Inc.
  294. This program is free software; you can redistribute it and/or modify
  295. it under the terms of the GNU General Public License as published by
  296. the Free Software Foundation; either version 2, or (at your option)
  297. any later version.
  298. This program is distributed in the hope that it will be useful,
  299. but WITHOUT ANY WARRANTY; without even the implied warranty of
  300. MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  301. GNU General Public License for more details.
  302. You should have received a copy of the GNU General Public License
  303. along with this program. If not, see <http://www.gnu.org/licenses/>.
  304. Local Variables:
  305. mode: text
  306. End: