Avoid config save callback in case of reconnection (updated) (#94)

* move code into src directory

* add gitignore file

* bump version

* fixes: comparison of integer expressions of different signedness

* fixes warning when using ESP8266

* removed unused variable

* reviewed code comments for consistency

* moved to flash a few more debug messages

* applied code formatting

* bump version to 0.27

* reviewed for consistency on variable type

* completely removed unsed handle204 leftovers

* removed unused code

* bump version to 0.28

* fixes build failure

* bump version to 0.29

* Avoid config save callback in case of reconnection

* bump version to 0.30

library.json

@@ -9,5 +9,5 @@
   },
   "frameworks": "arduino",
   "platforms": ["espressif8266", "espressif32"],
-  "version": "0.29"
+  "version": "0.30"
 }

library.properties

@@ -1,5 +1,5 @@
 name=ESP Async WiFi Manager
-version=0.29
+version=0.30
 author=alanswx
 maintainer=alanswx
 sentence=ESP8266 and ESP32 Async WiFi Connection manager with fallback web configuration portal

src/ESPAsyncWiFiManager.cpp

@@ -532,7 +532,7 @@ void AsyncWiFiManager::criticalLoop()
       // using user-provided _ssid, _pass in place of system-stored ssid and pass
       if (connectWifi(_ssid, _pass) != WL_CONNECTED)
       {
-        DEBUG_WM(F("Failed to connect."));
+        DEBUG_WM(F("Failed to connect"));
       }
       else
       {
@@ -579,6 +579,7 @@ boolean AsyncWiFiManager::startConfigPortal(char const *apName, char const *apPa
 
   _apName = apName;
   _apPassword = apPassword;
+  bool connectedDuringConfigPortal = false;
 
   // notify we entered AP mode
   if (_apcallback != NULL)
@@ -615,6 +616,7 @@ boolean AsyncWiFiManager::startConfigPortal(char const *apName, char const *apPa
       if (_tryConnectDuringConfigPortal)
       {
         WiFi.begin(); // try to reconnect to AP
+        connectedDuringConfigPortal = true;
       }
       scannow = millis();
     }
@@ -625,7 +627,8 @@ boolean AsyncWiFiManager::startConfigPortal(char const *apName, char const *apPa
       // connected
       WiFi.mode(WIFI_STA);
       // notify that configuration has changed and any optional parameters should be saved
-      if (_savecallback != NULL)
+      // configuraton should not be saved when just connected using stored ssid and password during config portal
+      if (!connectedDuringConfigPortal && _savecallback != NULL)
       {
         // TODO: check if any custom parameters actually exist, and check if they really changed maybe
         _savecallback();
@@ -654,7 +657,7 @@ boolean AsyncWiFiManager::startConfigPortal(char const *apName, char const *apPa
       }
       else
       {
-        DEBUG_WM(F("Failed to connect."));
+        DEBUG_WM(F("Failed to connect"));
       }
 
       if (_shouldBreakAfterConfig)
@@ -934,7 +937,7 @@ void AsyncWiFiManager::handleWifi(AsyncWebServerRequest *request, boolean scan)
     if (wifiSSIDCount == 0)
     {
       DEBUG_WM(F("No networks found"));
-      page += F("No networks found. Refresh to scan again.");
+      page += F("No networks found. Refresh to scan again");
     }
     else
     {
@@ -1204,7 +1207,7 @@ void AsyncWiFiManager::handleReset(AsyncWebServerRequest *request)
   page += FPSTR(HTTP_STYLE);
   page += _customHeadElement;
   page += FPSTR(HTTP_HEAD_END);
-  page += F("Module will reset in a few seconds.");
+  page += F("Module will reset in a few seconds");
   page += FPSTR(HTTP_END);
   request->send(200, "text/html", page);