Fixed Floating Labels

floating labels were part of OOOI logging, disabled for now

src/gui/dialogues/flightentryeditdialog.cpp

@@ -49,6 +49,11 @@ void FlightEntryEditDialog::init()
 
 void FlightEntryEditDialog::setupUI()
 {
+    // TODO implement OOIB logging, hide for now
+    timeOffLabel.hide();
+    timeOffLineEdit.hide();
+    timeOnLabel.hide();
+    timeOnLineEdit.hide();
     // setup layout
     // const int column0 = 0;
     // const int column1 = 1;
@@ -85,9 +90,9 @@ void FlightEntryEditDialog::setupUI()
 
     column = 0;
     thirdPilotLineEdit.setObjectName(QStringLiteral("thirdPilotLineEdit"));
-    timeOffLineEdit.setObjectName(QStringLiteral("timeOffLineEdit"));
+    timeOffLineEdit.setObjectName(QStringLiteral("timeOutLineEdit"));
     layout->addWidget(&timeOutLabel, ++row, column++);
-    layout->addWidget(&timeOffLineEdit, row, column++);
+    layout->addWidget(&timeOutLineEdit, row, column++);
     column++;
     layout->addWidget(&thirdPilotLabel, row, column++);
     layout->addWidget(&thirdPilotLineEdit, row, column++);
@@ -117,21 +122,17 @@ void FlightEntryEditDialog::setupUI()
 
 
     column = 0;
-    // TODO
-    // troubleshoot why this label is floating in the top right corner
-    takeOffCountLabel = new QLabel(tr("Take Off"), this);
-    landingCountLabel = new QLabel(tr("Landing"), this);
     layout->addWidget(&approachTypeLabel, ++row, column++);
     layout->addWidget(&approachTypeComboBox, row, column++);
     column++;
-    layout->addWidget(takeOffCountLabel, row, column++);
+    layout->addWidget(&takeOffCountLabel, row, column++);
     layout->addWidget(&takeOffCountSpinBox, row, column++);
 
     column = 0;
     layout->addWidget(&flightRulesLabel, ++row, column++);
     layout->addWidget(&flightRulesComboBox, row, column++);
     column++;
-    layout->addWidget(landingCountLabel, row, column++);
+    layout->addWidget(&landingCountLabel, row, column++);
     layout->addWidget(&landingCountSpinBox, row, column++);
 
     layout->addWidget(&acceptButtonBox, ++row, lastCol);

src/gui/dialogues/flightentryeditdialog.h

@@ -73,10 +73,8 @@ private:
     QLabel remarksLabel = QLabel(tr("Remarks"), this);
     QLabel flightNumberLabel = QLabel(tr("Flight Number"), this);
     QLabel pilotFlyingLabel = QLabel(tr("Pilot Flying"), this);
-    QLabel *takeOffCountLabel;
-    // QLabel takeOffCountLabel = QLabel(tr("Take Off"), this);
-    // QLabel landingCountLabel = QLabel(tr("Landing"), this);
-    QLabel *landingCountLabel;
+    QLabel takeOffCountLabel = QLabel(tr("Take Off"), this);
+    QLabel landingCountLabel = QLabel(tr("Landing"), this);
     QLabel totalTimeLabel = QLabel(tr("Total Time"), this);
     QLabel totalTimeDisplayLabel = QLabel("00:00", this);
     QLabel pilotFunctionLabel = QLabel(tr("Function"), this);

src/opl.h

@@ -75,11 +75,11 @@ constexpr static int STUB_ROW_ID = -1;
 /**
  * @brief Defines a four-letter code for a non-extistent (dummy) airport: "XXXX"
  */
-constexpr static auto STUB_AIRPORT_CODE = QLatin1String("XXXX");
+const static auto STUB_AIRPORT_CODE = QLatin1String("XXXX");
 /**
  * @brief Defines a registration for a non-existent (dummy) aircraft: "XX-XXX"
  */
-constexpr static auto STUB_AIRCRAFT_REG = QLatin1String("XX-XXX");
+const static auto STUB_AIRCRAFT_REG = QLatin1String("XX-XXX");
 
 /*!
  * \brief The decimal seperator used internally