Added placeholders for signals and slots

src/experimental/DataBase.cpp

@@ -2,6 +2,11 @@
 
 namespace experimental {
 
+/// [F] suggestions for signals:
+///
+/// commitSuccessful()
+/// commitUnSuccessful(QString sqlError, QString statement)
+
 DataBase* DataBase::instance = nullptr;
 
 DataBase* DataBase::getInstance()
@@ -130,11 +135,13 @@ bool DataBase::update(Entry updated_entry)
     if (q.lastError().type() == QSqlError::NoError)
     {
         DEB("Entry successfully committed.");
+        /// [F] emit commitSuccessful();
         return true;
     } else {
         DEB("Unable to commit.");
         DEB("Query: " << statement);
         DEB("Query Error: " << q.lastError().text());
+        /// [F] emit commitUnsuccessful(q.lastError().type(), statement);
         return false;
     }
 }
@@ -161,11 +168,13 @@ bool DataBase::insert(Entry newEntry)
     if (q.lastError().type() == QSqlError::NoError)
     {
         DEB("Entry successfully committed.");
+        /// [F] emit commitSuccessful();
         return true;
     } else {
         DEB("Unable to commit.");
         DEB("Query: " << statement);
         DEB("Query Error: " << q.lastError().text());
+        /// [F] emit commitUnsuccessful(q.lastError().type(), statement);
         return false;
     }
 
@@ -176,7 +185,6 @@ TableData DataBase::getEntryData(DataPosition dataPosition)
     // check table exists
     if (!tableNames.contains(dataPosition.first)) {
         DEB(dataPosition.first << " not a table in the database. Unable to retreive Entry data.");
-        // emit databaseError
         return TableData();
     }
 
@@ -188,14 +196,12 @@ TableData DataBase::getEntryData(DataPosition dataPosition)
     if (checkQuery.lastError().type() != QSqlError::NoError) {
         DEB("SQL error: " << checkQuery.lastError().text());
         DEB("Statement: " << statement);
-        // emit sqlError(selectQuery.lastError().text(), statement)
         return TableData();
     }
 
     checkQuery.next();
     if (checkQuery.value(0).toInt() == 0) {
         DEB("No Entry found for row id: " << dataPosition.second );
-        // emit databaseError("No Entry found for row id: " + dataPosition.second)
         return TableData();
     }
 
@@ -208,7 +214,6 @@ TableData DataBase::getEntryData(DataPosition dataPosition)
     if (selectQuery.lastError().type() != QSqlError::NoError) {
         DEB("SQL error: " << selectQuery.lastError().text());
         DEB("Statement: " << statement);
-        // emit sqlError(selectQuery.lastError().text(), statement)
         return TableData();
     }
 

src/gui/dialogues/newpilotdialog.cpp

@@ -102,10 +102,22 @@ void NewPilotDialog::on_buttonBox_accepted()
         mb.show();
     } else {
         submitForm();
-        accept();
+        accept(); /// [F] once the signals and slots are in place this line goes away as it is called in the slot below
     }
 }
 
+void NewPilotDialog::onCommitSuccessful()
+{
+    accept();
+}
+
+void NewPilotDialog::onCommitUnsuccessful(QString &sqlError, QString&)
+{
+    auto mb = QMessageBox(this);
+    mb.setText("The following error has ocurred. Your entry has not been saved./n/n"
+               + sqlError);
+}
+
 void NewPilotDialog::setupValidators()
 {
     DEB("Setting up Validators...");
@@ -170,7 +182,7 @@ void NewPilotDialog::submitForm()
     DEB("Pilot entry position: " << pilotEntry.position);
     DEB("Pilot entry data: " << pilotEntry.getData());
     DB()->commit(pilotEntry);
-    // to do: create signals and slots to handle unsuccessful commit
+    // to do: connect signals and slots to handle unsuccessful commit
     // onSuccessfulCommit, accept();
     // onError, show QMessageBox and prompt for user Input
 }

src/gui/dialogues/newpilotdialog.h

@@ -43,6 +43,10 @@ public:
     ~NewPilotDialog();
 private slots:
     void on_buttonBox_accepted();
+
+    void onCommitSuccessful();
+
+    void onCommitUnsuccessful(QString &sqlError, QString &);
 private:
     Ui::NewPilot *ui;